refactor: reuse timers instead of time.After in loops #687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reusing a timer repeatedly results in less GC than time.After in each loop iteration. Closes #122
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## main #687 +/- ##
==========================================
+ Coverage 60.32% 60.34% +0.01%
==========================================
Files 243 243
Lines 31004 31018 +14
==========================================
+ Hits 18704 18717 +13
- Misses 10635 10637 +2
+ Partials 1665 1664 -1
|
Jorropo
approved these changes
Oct 10, 2024
lidel
changed the title
lidel
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reusing a timer repeatedly results in less GC than time.After in each loop iteration.
Closes #122